added collision detection between primitives like circle, rectangle e…#13002
Open
Riyarajput053 wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
added collision detection between primitives like circle, rectangle e…#13002Riyarajput053 wants to merge 1 commit intoTheAlgorithms:masterfrom
Riyarajput053 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
mindaugl
reviewed
Sep 28, 2025
| return distance_squared <= radius_sum**2 | ||
|
|
||
| @staticmethod | ||
| def rectangle_rectangle_collision(rect1, rect2): |
Contributor
There was a problem hiding this comment.
This does not seem to work, e.g. rect1 = (x = 0, y = 0, width = 5, height = 2), rect2 = (x = 1, y = 10, width = 5, height = 2), would return collision.
Would make sense to add tests and do in 3 dimensions or name it 2D.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tc in physics
Describe your change:
The collision detection algorithm implemented in [collision_detection.py] is designed to detect collisions between basic geometric primitives: circles and rectangles. It includes methods for detecting collisions between two circles, two rectangles, and a circle with a rectangle.
Circle-Circle Collision
This method checks if two circles overlap by calculating the distance between their centers and comparing it to the sum of their radii.
Rectangle-Rectangle Collision
This method checks if two axis-aligned rectangles overlap by comparing their edges.
Circle-Rectangle Collision
This method checks if a circle overlaps with a rectangle by finding the closest point on the rectangle to the circle's center and checking if the distance to this point is less than the circle's radius.
Fixes: #12569
Checklist: